Remove unused RoomSummary cache

[jmartinesp]

Content

Remove roomSummariesByIdentifier, remove code adding and removing items but never retrieving one 🤡 .

Motivation and context

On one of the SDK upgrades this code was modified and the cache was no longer needed, but I didn't realise it until today.

Tests

There should be no behavior changes.

Tested devices

• Physical
• Emulator
• OS version(s): 14

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/5vjzC7

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.82%. Comparing base (366db47) to head (bedfc99).
Report is 8 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3647   +/-   ##
========================================
  Coverage    82.82%   82.82%           
========================================
  Files         1747     1747           
  Lines        41742    41742           
  Branches      5102     5102           
========================================
  Hits         34572    34572           
  Misses        5355     5355           
  Partials      1815     1815           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bmarty]

OK, thanks!