Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude preview from code coverage #2193

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jan 8, 2024

Replacement for #2190

Copy link
Contributor

github-actions bot commented Jan 8, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/e1zv6p

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a611cca) 69.44% compared to head (92d8e4f) 70.06%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2193      +/-   ##
===========================================
+ Coverage    69.44%   70.06%   +0.61%     
===========================================
  Files         1341     1335       -6     
  Lines        33273    32586     -687     
  Branches      7119     6758     -361     
===========================================
- Hits         23108    22832     -276     
+ Misses        6648     6482     -166     
+ Partials      3517     3272     -245     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty force-pushed the feature/bma/sxcludePreviewFromCodeCoverage branch from ff342f1 to 3df290d Compare January 8, 2024 13:16
@bmarty
Copy link
Member Author

bmarty commented Jan 9, 2024

Progress:
image

With ignoring ContentToPreview:
image

@bmarty bmarty force-pushed the feature/bma/sxcludePreviewFromCodeCoverage branch from 674fbb4 to 371065b Compare January 9, 2024 16:56
@bmarty bmarty marked this pull request as ready for review January 9, 2024 17:31
@bmarty bmarty requested a review from a team as a code owner January 9, 2024 17:31
@bmarty bmarty requested review from ganfra and removed request for a team January 9, 2024 17:31
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@bmarty bmarty merged commit 57b2a0d into develop Jan 11, 2024
15 checks passed
@bmarty bmarty deleted the feature/bma/sxcludePreviewFromCodeCoverage branch January 11, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants