Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use sublist as it crashes if index > items.count(). #2191

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jan 8, 2024

@bmarty bmarty requested a review from a team as a code owner January 8, 2024 10:29
@bmarty bmarty requested review from jmartinesp and removed request for a team January 8, 2024 10:29
Copy link
Contributor

github-actions bot commented Jan 8, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/UZZjCt

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a2df61) 66.98% compared to head (0756a2d) 66.98%.
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2191   +/-   ##
========================================
  Coverage    66.98%   66.98%           
========================================
  Files         1376     1376           
  Lines        34259    34260    +1     
  Branches      7459     7459           
========================================
+ Hits         22948    22949    +1     
  Misses        7686     7686           
  Partials      3625     3625           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit df36839 into develop Jan 8, 2024
15 checks passed
@bmarty bmarty deleted the feature/bma/fixRRCrash branch January 8, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants