Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SubcomposeLayout for ContentAvoidingLayout #2171

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Uses SubomposeLayout instead of just Layout for ContentAvoidingLayout.

Motivation and context

Fixes #2155.

Screenshots / GIFs

No change.

Tests

Hopefully, this won't cause performance issues.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner January 5, 2024 12:08
@jmartinesp jmartinesp requested review from bmarty and removed request for a team January 5, 2024 12:08
Copy link
Contributor

github-actions bot commented Jan 5, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/DrQzsu

Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e04780f) 66.99% compared to head (93a0121) 66.98%.

Files Patch % Lines
...imeline/components/layout/ContentAvoidingLayout.kt 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2171      +/-   ##
===========================================
- Coverage    66.99%   66.98%   -0.01%     
===========================================
  Files         1376     1376              
  Lines        34205    34201       -4     
  Branches      7444     7445       +1     
===========================================
- Hits         22916    22911       -5     
  Misses        7672     7672              
- Partials      3617     3618       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jan 5, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jan 5, 2024
@jmartinesp jmartinesp enabled auto-merge (squash) January 5, 2024 12:22
@jmartinesp jmartinesp merged commit 3a2191e into develop Jan 5, 2024
17 of 19 checks passed
@jmartinesp jmartinesp deleted the fix/jme/content-avoiding-layout-wrong-size branch January 5, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message content can be shown incomplete until scrolled off-screen and back
2 participants