Trim whitespace at the end of messages

[jmartinesp]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Trim whitespace at the end of both formatted and plain text messages. We don't trim leading whitespace in case it's used for formatting or some nice ASCII art.

             (__)    
     `\------(oo)
       ||    (__)
       ||w--||     \|/
   \|/

Motivation and context

Fixes #2099.

Screenshots / GIFs

Tests

• Send a message with one or several trailing whitespaces or new lines.

In the timeline those extra whitespace chars should be gone.

Tested devices

• Physical
• Emulator
• OS version(s): 14

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/RFfXfE

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4948748) 66.98% compared to head (877ec84) 66.99%.

Files	Patch %	Lines
...oid/libraries/matrix/ui/messages/ToHtmlDocument.kt	33.33%	0 Missing and 2 partials ⚠️
...ctories/event/TimelineItemContentMessageFactory.kt	96.66%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2169   +/-   ##
========================================
  Coverage    66.98%   66.99%           
========================================
  Files         1376     1376           
  Lines        34193    34201    +8     
  Branches      7441     7443    +2     
========================================
+ Hits         22905    22912    +7     
  Misses        7672     7672           
- Partials      3616     3617    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bmarty]

LGTM, but this code will trim only the last line, IIUC how trimEnd() works. Would it have sense to trimEnd all lines of the message? For instance having (with _ replacing for clarity):

a____
b__
c

become

a
b
c

?
We could replace trimEnd() with lines().joinToString(transform = String::trimEnd, separator = "\n") to do it.

On the other side I do not really like to apply post treatment on Events that have been sent...

[frebib]

This doesn't seem to solve the issue in the ping room, because I think you're only trimming the body and not the formattedBody where the issue actually is?

[jmartinesp]

This doesn't seem to solve the issue in the ping room, because I think you're only trimming the body and not the formattedBody where the issue actually is?

Sorry, you're right. I applied the trimEnd() at the wrong place 🤦 .

[frebib]

Looks great! Thanks

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud