fix linkify

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Ensure message with body and without formatted body got working links.
Also ensure email addresses are linkified.

Motivation and context

Closes #2038

Screenshots / GIFs

Tests

• Send a message with just a raw link and nothing else
• Observe that with this change the link in the message is rendered as a link and is clickable

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/fwSKHL

[ganfra]

If I understand correctly, we always have a formattedBody now with those fixes. Could we simplify a bit the TimelineItemTextBasedContent interface then?
It's a bit hard to know what to use currently, and we probably don't need all the fields.

sealed interface TimelineItemTextBasedContent : TimelineItemEventContent {
    val body: String
    val htmlDocument: Document?
    val formattedBody: CharSequence?
    val plainText: String
    val isEdited: Boolean
    val htmlBody: String?
        get() = htmlDocument?.body()?.html()
}

[bmarty]

we always have a formattedBody

No, withLinks() returns null if no links are added.

[ganfra]

Can we still try to simplify the api?
If we could get a plainText/formattedText/body/htmlBody and remove the htmlDocument instance?
I'd say, The formattedText shouldn't be nullable and should always be displayed in timeline.

[bmarty]

Yes, but I would prefer to do that in a separate rework PR. OK for you?

[ganfra]

as u want

[frebib]

Would we ever consider also detecting and formatting raw user/room mentions in this way too, for clients that only send unformatted bodies?

[bmarty]

consumeItemsUntilPredicate now expects the predicate to be true at some point, so I had to fix this outdated test.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4c987c5) 67.64% compared to head (0129fdd) 67.61%.

Files	Patch %	Lines
...ctories/event/TimelineItemContentMessageFactory.kt	92.85%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2040      +/-   ##
===========================================
- Coverage    67.64%   67.61%   -0.03%     
===========================================
  Files         1349     1349              
  Lines        33813    33819       +6     
  Branches      7263     7268       +5     
===========================================
- Hits         22872    22867       -5     
- Misses        7493     7503      +10     
- Partials      3448     3449       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.