Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invite wording #2039

Merged
merged 5 commits into from
Dec 18, 2023
Merged

Fix invite wording #2039

merged 5 commits into from
Dec 18, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 15, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fix wording in room invite members view: Send -> Invite

Motivation and context

Closes #2037

Screenshots / GIFs

See recorded one (in progress)

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner December 15, 2023 12:03
@bmarty bmarty requested review from jmartinesp and ganfra and removed request for a team and jmartinesp December 15, 2023 12:03
Copy link
Contributor

github-actions bot commented Dec 15, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Wz8Jy6

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 15, 2023
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 15, 2023
Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9130ecb) 67.60% compared to head (23d664d) 67.60%.
Report is 14 commits behind head on develop.

Files Patch % Lines
...s/roomdetails/impl/invite/RoomInviteMembersView.kt 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2039   +/-   ##
========================================
  Coverage    67.60%   67.60%           
========================================
  Files         1349     1349           
  Lines        33786    33786           
  Branches      7261     7261           
========================================
  Hits         22841    22841           
  Misses        7496     7496           
  Partials      3449     3449           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 18, 2023
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 18, 2023
@bmarty bmarty merged commit 040fc3f into develop Dec 18, 2023
17 of 18 checks passed
@bmarty bmarty deleted the feature/bma/fixInviteWording branch December 18, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong string for "Invite users to a room"
2 participants