Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadReceipt #2015

Merged
merged 3 commits into from
Dec 14, 2023
Merged

ReadReceipt #2015

merged 3 commits into from
Dec 14, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 13, 2023

First commit is a fix on the build script, which was not working properly if the SDK was not located at the same folder level that the Android project, i.e. at ../location.

SDK update to 0.1.77 and fix API break, use ReceiptType.READ as I think this is equivalent.

@ElementBot
Copy link
Collaborator

ElementBot commented Dec 14, 2023

Warnings
⚠️

gradle/libs.versions.toml#L8 - A newer version of com.android.tools.build:gradle than 8.1.4 is available: 8.2.0

⚠️

gradle/libs.versions.toml#L18 - A newer version of androidx.lifecycle:lifecycle-runtime-ktx than 2.7.0-rc01 is available: 2.7.0-rc02

⚠️

gradle/libs.versions.toml#L19 - A newer version of androidx.activity:activity-compose than 1.8.1 is available: 1.8.2

⚠️

gradle/libs.versions.toml#L24 - A newer version of androidx.compose.compiler:compiler than 1.5.4 is available: 1.5.6

⚠️

gradle/libs.versions.toml#L70 - A newer version of androidx.annotation:annotation-jvm than 1.7.0 is available: 1.7.1

⚠️

gradle/libs.versions.toml#L73 - A newer version of androidx.exifinterface:exifinterface than 1.3.6 is available: 1.3.7

⚠️

gradle/libs.versions.toml#L94 - A newer version of androidx.compose.material3:material3 than 1.2.0-alpha12 is available: 1.2.0-beta01

Generated by 🚫 dangerJS against e288e6a

Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Pi1T3J

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d8c597d) 67.72% compared to head (e288e6a) 67.73%.
Report is 18 commits behind head on develop.

Files Patch % Lines
...libraries/designsystem/components/avatar/Avatar.kt 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2015      +/-   ##
===========================================
+ Coverage    67.72%   67.73%   +0.01%     
===========================================
  Files         1327     1328       +1     
  Lines        33607    33622      +15     
  Branches      7249     7249              
===========================================
+ Hits         22761    22775      +14     
- Misses        7413     7414       +1     
  Partials      3433     3433              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty marked this pull request as ready for review December 14, 2023 11:41
@bmarty bmarty requested a review from a team as a code owner December 14, 2023 11:41
@bmarty bmarty requested review from jmartinesp and removed request for a team December 14, 2023 11:41
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 14, 2023
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 14, 2023
@bmarty bmarty disabled auto-merge December 14, 2023 15:03
@bmarty bmarty merged commit e725747 into develop Dec 14, 2023
16 of 18 checks passed
@bmarty bmarty deleted the feature/bma/asyncMedia branch December 14, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants