Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poll history UI #1913

Merged
merged 28 commits into from
Dec 14, 2023
Merged

Poll history UI #1913

merged 28 commits into from
Dec 14, 2023

Conversation

julioromano
Copy link

@julioromano julioromano commented Nov 28, 2023 •
edited by ganfra
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Poll history of a room is now accessible from the room details screen.

Motivation and context

Closes #2014

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@julioromano julioromano self-assigned this Nov 28, 2023
@julioromano julioromano mentioned this pull request Nov 28, 2023
Closed
6 tasks
@julioromano julioromano force-pushed the julioromano/poll_history_entry_point branch 4 times, most recently from dff5c78 to 8059083 Compare November 30, 2023 09:17
@julioromano julioromano force-pushed the julioromano/poll_history_entry_point branch from 8059083 to d0d73e0 Compare December 1, 2023 08:28
@julioromano julioromano assigned jmartinesp and unassigned julioromano Dec 1, 2023
@ganfra ganfra assigned ganfra and unassigned jmartinesp Dec 4, 2023
ganfra and others added 14 commits December 5, 2023 14:06
Polls: share logic around PollContent
4a2cbb1
PollHistory : simplify so we only have one Node. Also enrich PollHist…
aa96931 
…oryState.
Theme : introduce SegmentedButton
954df6c
PollHistory : use the new PollHistoryState in the view
891c05a
@ganfra
Timeline: exposes simple request for backward pagination
449c331
@ganfra
Poll history : use pager to keep scrolling state when switching filter
7307e0f
@ganfra
Poll history : use localazy strings
a2c5cdf
@ganfra
Poll history : branch edit flow
3be1267
@ganfra
Timeline : avoid crash when destroying
e76bafc
@ganfra
PollHistory : use the regular timeline instead of pollHistory timelin…
5282e1c 
…e as not working properly.
@ganfra
Poll history : add empty state
8f1e139
@ganfra
Poll history : add tests and fix others
6378f6c
@ganfra
Merge branch 'develop' into julioromano/poll_history_entry_point
863d156
Update screenshots
6aac8f3
@ganfra ganfra marked this pull request as ready for review December 13, 2023 16:43
@ganfra ganfra requested a review from a team as a code owner December 13, 2023 16:43
@ganfra ganfra requested review from bmarty and removed request for a team December 13, 2023 16:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2023 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/b7s2vz

@ganfra ganfra changed the title WIP: Poll history UI Poll history UI Dec 14, 2023
@ganfra ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 14, 2023
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 14, 2023
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 14, 2023
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 14, 2023
bmarty
bmarty approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, fixing an issue on preview, and triggered a record.

@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 14, 2023
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 14, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bmarty bmarty disabled auto-merge December 14, 2023 20:46
@bmarty bmarty merged commit 7283732 into develop Dec 14, 2023
13 checks passed
@bmarty bmarty deleted the julioromano/poll_history_entry_point branch December 14, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

@ElementBot ElementBot Awaiting requested review from ElementBot

Assignees

@ganfra ganfra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Poll history [UI]
4 participants
@julioromano @bmarty @jmartinesp @ganfra