Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cross-signing status ui after activation in settings #7714

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

NicolasBuquet
Copy link

When activating cross-signing in Security settings, either directly or by activating Secure Backup, the cross-signing status is not updated in UI.

If you leave Security Settings and open it back right away, the cross-signing status is updated.

Update it right after activation without having to leave the screen.

Pull Request Checklist

  • [X ] I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • [X ] Pull request is based on the develop branch
  • [X ] Pull request contains a changelog file in ./changelog.d
  • [X ] You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • [X ] Pull request includes a sign off

Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d50b82a) 12.37% compared to head (be4fbc3) 12.03%.
Report is 25 commits behind head on develop.

Files Patch % Lines
...Modules/Settings/Security/SecurityViewController.m 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7714      +/-   ##
===========================================
- Coverage    12.37%   12.03%   -0.34%     
===========================================
  Files         1650     1650              
  Lines       163869   163920      +51     
  Branches     67267    67277      +10     
===========================================
- Hits         20277    19727     -550     
- Misses      142927   143533     +606     
+ Partials       665      660       -5     
Flag Coverage Δ
uitests 55.03% <ø> (+0.06%) ⬆️
unittests 5.86% <0.00%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Nicolas Buquet seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants