Update ElasticSearch to 8.4 and support for routing #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timgws have you had any chance to take a look at this PR? I'm happy to change anything you don't like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes some bugs with pagination. Cleaned up and removed functions that ES has removed. Fixed the tests so they correspond to what ES returns.
As ES 7 forward has removed types, this change will incorporate the type (table name) into the index name.
This probably needs to be tagged as version 2.x as it will destroy backwards compatibility.
If there's something you want me to do in a different way, just give me the heads up and I'll look into it!