Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] fix broken story in Prompt Custom Actions #149992

Merged
merged 4 commits into from
Feb 6, 2023
Merged

[Fix] fix broken story in Prompt Custom Actions #149992

merged 4 commits into from
Feb 6, 2023

Conversation

rshen91
Copy link
Contributor

@rshen91 rshen91 commented Jan 31, 2023 •
edited
Loading

Summary

This is actually an issue with Storybook not with the component. storybookjs/storybook#11554

This PR updates the README.mdx with a proper example and fixes the story because of storybook's limitation.

In reviewing a PR I saw that the packages/shared-ux/prompt/not_found/src/not_found_prompt.stories.tsx story for CustomActions was broken. It was passing in an array leading to the below error:
Screenshot 2023-01-31 at 3 27 45 PM

This PR also shows the customization of the title and body prop added in PR #149924

Checklist

  • Documentation was added for features that require explanation or tutorials

rshen91
rshen91 commented Feb 1, 2023
View reviewed changes
packages/shared-ux/prompt/not_found/src/not_found_prompt.stories.tsx
</EuiButtonEmpty>,
]}
actions={
<>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a storybook issue in not being able to read the values of the array. I added the test to confirm that the component does render as expected.

@rshen91 rshen91 marked this pull request as ready for review February 1, 2023 17:06
@rshen91 rshen91 requested a review from a team as a code owner February 1, 2023 17:06
@rshen91 rshen91 added the release_note:skip Skip the PR/issue when compiling release notes label Feb 1, 2023
@rshen91 rshen91 removed the request for review from majagrubic February 2, 2023 15:37
majagrubic
majagrubic approved these changes Feb 4, 2023
View reviewed changes
Copy link
Contributor

@majagrubic majagrubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, changes seem straightforward.

@rshen91 rshen91 enabled auto-merge (squash) February 6, 2023 15:01
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rshen91 rshen91 merged commit 212d57c into elastic:main Feb 6, 2023
@kibanamachine kibanamachine added v8.7.0 backport:skip This commit does not require backporting labels Feb 6, 2023
@rshen91 rshen91 deleted the fix-story branch February 6, 2023 16:26
darnautov pushed a commit to darnautov/kibana that referenced this pull request Feb 7, 2023
@rshen91 @darnautov
[Fix] fix broken story in Prompt Custom Actions (elastic#149992)
e60a4f7
benakansara pushed a commit to benakansara/kibana that referenced this pull request Feb 7, 2023
@rshen91 @benakansara
[Fix] fix broken story in Prompt Custom Actions (elastic#149992)
f618eaf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majagrubic majagrubic majagrubic approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rshen91 @kibana-ci @majagrubic @kibanamachine