Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rum-core): run tasks that block Angular stabilization in a separate Zone #1344

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pappkamerad
Copy link

Fixes #983

This adds a runInOwnZone helper function to wrap tasks that would block Angular stabilization otherwise.

Check the issue for more details.

@cla-checker-service
Copy link

cla-checker-service bot commented Feb 24, 2023

💚 CLA has been signed

@apmmachine
Copy link
Contributor

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-24T09:19:22.099+0000

  • Duration: 1 min 42 sec

Steps errors 2

Expand to view the steps failures

Load a resource file from a library
  • Took 0 min 0 sec . View more details here
  • Description: approval-list/elastic/apm-agent-rum-js.yml
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/pappkamerad return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/pappkamerad : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/pappkamerad : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pappkamerad
Copy link
Author

/test

@devcorpio
Copy link
Contributor

devcorpio commented Mar 8, 2023

Hi @pappkamerad,

Thanks a lot for your contribution!

Currently, we have limited availability to review your PR - due to project priorities within the team - we'll let you know once we are ready to review it

Thanks for your time,

Alberto

@mitchschedulicity
Copy link

Would love to see this approved and merged. It is currently a huge obstacle for our automated testing team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

throttle() function causes Angular to not get stable
4 participants