Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clickable transport and stops + refactor stop modal #75

Merged
merged 3 commits into from
Sep 3, 2023
Merged

Clickable transport and stops + refactor stop modal #75

merged 3 commits into from
Sep 3, 2023

Conversation

hiba9201
Copy link
Contributor

@hiba9201 hiba9201 commented Sep 3, 2023

  • updated redux actions for not clearing prev state
  • refactored Stop modal
  • moved location marker to bottom
  • made clickable transport and stop in card for stop and transport respectively

@hiba9201 hiba9201 added the client Changes in /client label Sep 3, 2023
@hiba9201 hiba9201 self-assigned this Sep 3, 2023
sashachabin
sashachabin reviewed Sep 3, 2023
View reviewed changes
common/types/strapi.ts Outdated Show resolved Hide resolved
sashachabin
sashachabin approved these changes Sep 3, 2023
View reviewed changes
Copy link
Member

@sashachabin sashachabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hiba9201 hiba9201 merged commit 1b32c76 into main Sep 3, 2023
1 check passed
@hiba9201 hiba9201 deleted the feat-clickable-transport branch September 3, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashachabin sashachabin sashachabin approved these changes

Assignees

@hiba9201 hiba9201

Labels
client Changes in /client
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiba9201 @sashachabin @ekbdev