PIDLookup: define momentum cuts to set an explicit boundary between TOF and hpDIRC domains #1518
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veprbl
force-pushed
the
pr/PID_table_cuts
branch
5 times, most recently
from
947b38d
to
7863242
Compare
…TOF and hpDIRC domains Currently DIRC is processed after TOF, and will replace previously looked up TOF values whenever DIRC has a table entry.
veprbl
force-pushed
the
pr/PID_table_cuts
branch
from
7863242
to
e958924
Compare
Capybara summary for PR 1518 |
|
|
@ohartbri Will you have a chance to review this in the next week? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Currently DIRC is processed after TOF, and will replace previously looked up TOF values whenever DIRC has a table entry.$|\vec{p}| > 2.5$ GeV.
The new approach is to use DIRC values only for
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
Yes