feat: create a new setting USE_DISCUSSIONS_MFE (#809) #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: create a new setting USE_DISCUSSIONS_MFE * feat: add new setting USE_DISCUSSIONS_MFE * fix: quality checks * fix: add setting override * fix: add setting override * fix: add setting override * fix: pep 8 violations * fix: update setting name Co-authored-by: Brayan Cerón <[email protected]> * fix: change variable name --------- Co-authored-by: Brayan Cerón <[email protected]>
magajh
reviewed
Aug 7, 2024
| True if the MFE setting is activated, by default | ||
| the MFE is deactivated | ||
| """ | ||
| ENABLE_MFE_FOR_TESTING = SettingDictToggle( |
There was a problem hiding this comment.
Maybe I'm missing some context here, but is there a particular reason why this setting is named ENABLE_MFE_FOR_TESTING? The name doesn't specify that it's for the Discussions MFE, and including the word 'testing' also seems out of place
|
Is there a reason we'd want to disable the discussions MFE by tenant? Can we explain it in the cover letter? Thanks! |
|
I will close this understanding we decided to use edx-platform as upstream is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of the Flag for enable/disable discussions MFE by tenant