Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup es lint issue 85 #87

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Setup es lint issue 85 #87

wants to merge 2 commits into from

Conversation

yuan-93
Copy link
Contributor

@yuan-93 yuan-93 commented Jun 2, 2024

resolve #85 Setup ESLint

neSpecc
neSpecc reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things to do:

  • add a yarn lint and yarn lint:fix scripts to the package.json
  • run lint and fix all issues
  • setup GitHub ESlint action to check eslint on all PRs

@neSpecc neSpecc self-requested a review June 17, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc Awaiting requested review from neSpecc

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup ESLint
2 participants
@yuan-93 @neSpecc