feat(typescript): refactor paragraph tool #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
neSpecc
reviewed
Feb 16, 2023
| /** | ||
| * Tool data for input and output | ||
| */ | ||
| private _data: ParagraphToolData = {}; |
There was a problem hiding this comment.
Suggested change
| private _data: ParagraphToolData = {}; | |
| private data: ParagraphToolData = {}; |
There was a problem hiding this comment.
There are already getters and setters for data. So, there is no point in changing.
| */ | ||
| private readonly placeholder: string; | ||
|
|
||
| private readonly preserveBlank: boolean; |
There was a problem hiding this comment.
duplication. You already have config
GeekaN2
force-pushed
the
feat/add-ts-support
branch
from
d3f4b7d
to
d060cf7
Compare
GeekaN2
force-pushed
the
feat/add-ts-support
branch
from
d060cf7
to
3959139
Compare
neSpecc
reviewed
Mar 31, 2023
Comment on lines
+46
to
+56
| export interface PasteConfig { | ||
| tags: string[]; | ||
| } | ||
|
|
||
| /** | ||
| * Used by Editor API to display the module in the toolbox | ||
| */ | ||
| export interface Toolbox { | ||
| icon: string; | ||
| title: string; | ||
| } |
There was a problem hiding this comment.
why do you need these types?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've replaced Webpack builder with Vite. Also, I've added TypeScript support. Now builder generates declaration files.