Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode time_dim based on monthlyVerificationDate #393

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

EddyCMWF
Copy link
Contributor

Some monthly data use the monthlyVarificationDate as the valid time. This PR adds a new time_dim, valid_month, which is a datetime based on the monthlyVerificationDate and the dataTime.

Also, cfgrib now warns when time_dims not recognised, previously it raised an error even though it can produce a valid result, albeit without a nicely decoded time dimension.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 41.26%. Comparing base (32624c5) to head (ba56258).

Files Patch % Lines
cfgrib/dataset.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
+ Coverage   41.15%   41.26%   +0.10%     
==========================================
  Files          26       26              
  Lines        2170     2174       +4     
  Branches      284      284              
==========================================
+ Hits          893      897       +4     
  Misses       1277     1277              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iainrussell iainrussell merged commit 8b8e896 into master Jul 18, 2024
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants