Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file-output): add Message as an extended method for V2xMessageReception #400

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

kschrab
Copy link
Contributor

@kschrab kschrab commented Aug 8, 2024

Description

It is now possible to print details of the V2xMessage via file output for V2xMessageReception interactions:

<subscription id="V2xMessageTransmission"/>
<subscription id="V2xMessageReception">
    <entries>
        <entry>Time</entry>
        <entry>Type</entry>
        <entry>Message.Payload.EffectiveLength</entry>
        <entry>ReceiverName</entry>
    </entries>
</subscription>

Affected parts of the online documentation

Documentation will be extended.

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@kschrab kschrab changed the title feat(file-output): add Payload as an extended method for V2xMessageReception feat(file-output): add Message as an extended method for V2xMessageReception Aug 8, 2024
@kschrab kschrab self-assigned this Aug 8, 2024
@kschrab kschrab requested a review from schwepmo August 8, 2024 08:38
Copy link
Contributor

@schwepmo schwepmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor remark regarding a checkstyle warning

@@ -46,6 +46,10 @@ static public Object getType(V2xMessageReception interaction) {
return message.getSimpleClassName();
}

static public V2xMessage getMessage(V2xMessageReception interaction) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a new Checkstyle warning regarding the positioning of this method, which I don't quite get.
Moving this method further down will probably fix it though.

Copy link
Contributor Author

@kschrab kschrab Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess because I put it between getType(V2xMessageTransmission interaction) and getType(V2xMessageReception interaction). I re-ordered the methods.

@kschrab kschrab requested a review from schwepmo August 8, 2024 14:17
@schwepmo schwepmo merged commit 3502596 into main Aug 8, 2024
6 checks passed
@schwepmo schwepmo deleted the 778-file-output-payload branch August 8, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants