Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure fixedOrder globally instead for every spawner #350

Merged
merged 10 commits into from
Oct 4, 2023

Conversation

kschrab
Copy link
Contributor

@kschrab kschrab commented Sep 13, 2023

Description

  • Instead of configuring fixedOrder for every vehicles spawner, it can now be configured once in the common configuration section of the mapping_config.json
  • This also allows to consider this config when transforming ScenarioVehicleRegistration to VehicleRegistration

Issue(s) related to this PR

  • Resolves internal issue 678

Affected parts of the online documentation

Changes in the documentation required?

Yes, separate MR is created.

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@kschrab kschrab added the enhancement New feature or request label Sep 13, 2023
@kschrab
Copy link
Contributor Author

kschrab commented Sep 21, 2023

@rprotzmann all tests are green again, needed to set fixedOrder = true for some test scenarios as this affected how vehicles were expected to be mapped for the test asserts. feel free to merge

@schwepmo schwepmo merged commit 4c3b72d into main Oct 4, 2023
3 checks passed
@schwepmo schwepmo deleted the 678-fixed-order-globally branch October 4, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants