Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Core] Extended allowed chars in KapuaEntity.name #4113

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Oct 3, 2024

This PR extends the allowed chars in KapuaEntity names

Related Issue
None

Description of the solution adopted
Added a new validation regex which includes:

  • alphanumerics
  • .
  • -
  • whitespace
  • :
  • _

Screenshots
None

Any side note on the changes made
None

@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 16.81%. Comparing base (2fa91c0) to head (3129029).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...pse/kapua/service/job/internal/JobServiceImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4113   +/-   ##
==========================================
  Coverage      16.81%   16.81%           
  Complexity        22       22           
==========================================
  Files           2019     2019           
  Lines          52411    52412    +1     
  Branches        4417     4417           
==========================================
+ Hits            8812     8813    +1     
  Misses         43202    43202           
  Partials         397      397           
Files with missing lines Coverage Δ
.../eclipse/kapua/commons/util/ArgumentValidator.java 77.41% <100.00%> (ø)
...pse/kapua/commons/util/CommonsValidationRegex.java 100.00% <100.00%> (ø)
...pse/kapua/service/job/internal/JobServiceImpl.java 0.00% <0.00%> (ø)

@Coduz Coduz force-pushed the feat-extendedEntityNameCharset branch from 5c0694d to 3129029 Compare October 3, 2024 14:03
@Coduz Coduz merged commit 9a91016 into eclipse:develop Oct 3, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
Development

Successfully merging this pull request may close these issues.

1 participant