Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openapi): Added OpenAPI mappings for deviceConfigurationStoreService DeviceApplicationSettings #3833

Merged

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Jul 28, 2023

This PR adds the Openapi mappings for the following resources:

  • DeviceConfigurationStoreService.getApplicationSettings()
  • DeviceConfigurationStoreService.setApplicationSettings(...)

Related Issue
This PR adds a missing part of #3601
This PR depends on #3832

Description of the solution adopted
Added mappings of new resources

Screenshots
None

Any side note on the changes made
Since it has been never released I've changed POST in PUT while applying settings. This is not a breaking changed though

@Coduz Coduz added Enhancement This PR/Issue improves an part of Kapua Documentation Doc... What?? Joke! We will write some! labels Jul 28, 2023
@Coduz Coduz force-pushed the feat-deviceConfigurationStoreOpenAPIMappings branch 2 times, most recently from c82b87c to 63e703f Compare July 28, 2023 10:59
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #3833 (558e524) into develop (9cbe18c) will not change coverage.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

❗ Current head 558e524 differs from pull request most recent head 63e703f. Consider uploading reports for the commit 63e703f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3833   +/-   ##
==========================================
  Coverage      20.56%   20.56%           
  Complexity         6        6           
==========================================
  Files           1896     1896           
  Lines          40498    40498           
  Branches        3878     3878           
==========================================
  Hits            8327     8327           
  Misses         31759    31759           
  Partials         412      412           
Files Changed Coverage Δ
...resources/v1/resources/DeviceManagementAssets.java 0.00% <ø> (ø)
...s/v1/resources/DeviceManagementConfigurations.java 0.00% <ø> (ø)

@Coduz Coduz force-pushed the feat-deviceConfigurationStoreOpenAPIMappings branch from 63e703f to 2cac2c1 Compare July 31, 2023 12:33
…vice DeviceApplicationSettings

Signed-off-by: Alberto Codutti <[email protected]>
@Coduz Coduz force-pushed the feat-deviceConfigurationStoreOpenAPIMappings branch from 2cac2c1 to b0158db Compare July 31, 2023 12:39
@Coduz Coduz merged commit 4456841 into eclipse:develop Jul 31, 2023
2 of 3 checks passed
@Coduz Coduz deleted the feat-deviceConfigurationStoreOpenAPIMappings branch July 31, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Doc... What?? Joke! We will write some! Enhancement This PR/Issue improves an part of Kapua
Projects
Development

Successfully merging this pull request may close these issues.

1 participant