-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactorings/repository pattern #3726
Merged
riccardomodanese
merged 146 commits into
eclipse:develop
from
dseurotech:refactorings/repositoryPattern
Aug 8, 2023
Merged
Refactorings/repository pattern #3726
riccardomodanese
merged 146 commits into
eclipse:develop
from
dseurotech:refactorings/repositoryPattern
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3726 +/- ##
=============================================
- Coverage 20.61% 20.42% -0.20%
Complexity 6 6
=============================================
Files 1902 1935 +33
Lines 40721 41503 +782
Branches 3878 3946 +68
=============================================
+ Hits 8395 8476 +81
- Misses 31914 32630 +716
+ Partials 412 397 -15
|
dseurotech
force-pushed
the
refactorings/repositoryPattern
branch
11 times, most recently
from
March 8, 2023 16:44
372050b
to
a66006b
Compare
dseurotech
force-pushed
the
refactorings/repositoryPattern
branch
7 times, most recently
from
March 16, 2023 13:29
b163215
to
003cc3d
Compare
dseurotech
force-pushed
the
refactorings/repositoryPattern
branch
11 times, most recently
from
March 27, 2023 07:41
eef1f14
to
2b469fb
Compare
Signed-off-by: dseurotech <[email protected]>
…ity methods where possible instead of reinventing the wheel Signed-off-by: dseurotech <[email protected]>
Signed-off-by: dseurotech <[email protected]>
…saction context Signed-off-by: dseurotech <[email protected]>
Signed-off-by: dseurotech <[email protected]>
Signed-off-by: dseurotech <[email protected]>
… framework Signed-off-by: dseurotech <[email protected]>
Signed-off-by: dseurotech <[email protected]>
Signed-off-by: dseurotech <[email protected]>
… in the future Signed-off-by: dseurotech <[email protected]>
…verriding delete and override methods a million times Signed-off-by: dseurotech <[email protected]>
Signed-off-by: dseurotech <[email protected]>
…the old event system without reworking it completely Signed-off-by: dseurotech <[email protected]>
… for cross-boundary calls Signed-off-by: dseurotech <[email protected]>
…to hook the old event system without reworking it completely" This reverts commit b960501.
Signed-off-by: dseurotech <[email protected]>
Signed-off-by: dseurotech <[email protected]>
…oundary of authorization Signed-off-by: dseurotech <[email protected]>
Signed-off-by: dseurotech <[email protected]>
…h in-memory repositories
…y;ManagerFactory every time) Signed-off-by: dseurotech <[email protected]>
Signed-off-by: dseurotech <[email protected]>
dseurotech
force-pushed
the
refactorings/repositoryPattern
branch
from
August 7, 2023 09:48
cf1f199
to
705ca1d
Compare
riccardomodanese
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CQ pending
This PR needs a CQ to be approved from Eclipse before merging.
Enhancement
This PR/Issue improves an part of Kapua
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the static DAOs in favour of injectable Repositories, and introduces transaction management within services.
Related Issue
This PR expands upon (and includes) #3705
Description of the solution adopted
PR3726 - DAOs to Repositories Presentation.pdf
Usage of static DAOS has been replaced by injectable Repositories (see org.eclipse.kapua.storage.KapuaEntityRepository and subclasses), with proper transaction management (TxManager class), and more flexible cache management with the KapuaEntityRepositoryCachingWrapper and subclasses.
Any side note on the changes made
The changes in this PR affect indirectly the generation of events (now explicit, as per slides) and the wiring of ServiceModules (that now need to be explicitly declared in the module's wiring)
Deprecations