Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider node's size when computing available space in port placement #955

Merged
merged 9 commits into from
Apr 9, 2024
Merged

Consider node's size when computing available space in port placement #955

merged 9 commits into from
Apr 9, 2024

Commits on Sep 7, 2023

  1. Consider node's size when computing available space in port placement

    @Eddykasp
    Eddykasp committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    b7941df View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. fix typo

    @Eddykasp
    Eddykasp committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    6a15c2c View commit details
    Browse the repository at this point in the history

  2. expand comments

    @Eddykasp
    Eddykasp committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    9403c6f View commit details
    Browse the repository at this point in the history

  3. Update test 

    Let test also allow node's set height as correct if it is greater than
the the minimum height needed according to the ports. This may not be
the desired solution.
    @Eddykasp
    Eddykasp committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    86d8fbe View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Add top-down property to nodeContext 

    Only consider existing node height in the top-down layout case
    @Eddykasp
    Eddykasp committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    d665f44 View commit details
    Browse the repository at this point in the history

  2. Revert changes to test case

    @Eddykasp
    Eddykasp committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    19bdd1c View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Add test 

    Tests that in the bottom-up case and in the top-down case
port positions are calculated as expected.
    @Eddykasp
    Eddykasp committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    285f9b6 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Merge branch 'master' into port-placement-calculation

    @Eddykasp
    Eddykasp committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    fea4fa4 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Merge remote-tracking branch 'upstream/master' into port-placement-ca… 

    …lculation
    @Eddykasp
    Eddykasp committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    cd7d2bb View commit details
    Browse the repository at this point in the history