Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layered: Actually change the area index for hyperedge splitting. #946

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

soerendomroes
Copy link
Contributor

Fixes #944

Thanks @Quantum64

@soerendomroes soerendomroes added bug Erroneous behaviour. alg-layered Affects the ELK Layered algorithm. labels Jul 20, 2023
@soerendomroes soerendomroes added this to the Release 0.9.0 milestone Jul 20, 2023
@Quantum64
Copy link

I'm currently reimplementing the ELK Layered algorithm in Rust and I'll be sure to report any other weirdness I catch as well.

@soerendomroes
Copy link
Contributor Author

I'm currently reimplementing the ELK Layered algorithm in Rust and I'll be sure to report any other weirdness I catch as well.

Thank you. Do you have any particular reason to reimplement ELK in Rust?

@soerendomroes soerendomroes merged commit 56270d7 into eclipse:master Jul 20, 2023
4 checks passed
@soerendomroes soerendomroes deleted the sdo/hyperEdgeAreaFix branch July 20, 2023 14:12
@Quantum64
Copy link

I'm currently reimplementing the ELK Layered algorithm in Rust and I'll be sure to report any other weirdness I catch as well.

Thank you. Do you have any particular reason to reimplement ELK in Rust?

I'm experimenting with using it in a Rust application that contains a graph editor. Using the Java implementation directly (perhaps as a daemon that a native app connects to) isn't possible due to particular implementation restrictions on this app. Plus it's just fun to go through this algorithm and really learn how it works.

Not to worry - I will be sure to open source my implementation prior to its distribution in any software product in compliance with the Eclipse Public License.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alg-layered Affects the ELK Layered algorithm. bug Erroneous behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HyperEdgeSegmentSplitter does not return the best area
2 participants