Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radial layout: center on root option #941

Merged
merged 5 commits into from
Jul 6, 2023

Conversation

Eddykasp
Copy link
Contributor

@Eddykasp Eddykasp commented Jul 3, 2023

This option allows a radial to be automatically centered on its root node. This is achieved by increasing the overall size of the layout and shifting all nodes accordingly.

This is done by increasing the overall size of the layout and shifting
the entire layout such that the root node is positioned exactly in the
center.

Signed-off-by: Max Kasperowski <[email protected]>
@soerendomroes soerendomroes added this to the Release 0.9.0 milestone Jul 3, 2023
@soerendomroes soerendomroes added the alg-radial Affects the ELK Radial algorithm. label Jul 3, 2023
Copy link
Contributor

@soerendomroes soerendomroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered adding a test for this?

@Eddykasp
Copy link
Contributor Author

Eddykasp commented Jul 3, 2023

Have you considered adding a test for this?

I thought you might ask that. I'll add that and address the other things as well.

@Eddykasp Eddykasp closed this Jul 4, 2023
@Eddykasp Eddykasp reopened this Jul 4, 2023
test/org.eclipse.elk.alg.radial.test/.project Outdated Show resolved Hide resolved
test/org.eclipse.elk.alg.radial.test/META-INF/MANIFEST.MF Outdated Show resolved Hide resolved
test/org.eclipse.elk.alg.radial.test/build.properties Outdated Show resolved Hide resolved
test/org.eclipse.elk.alg.radial.test/pom.xml Outdated Show resolved Hide resolved
@soerendomroes soerendomroes merged commit e878d4c into eclipse:master Jul 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alg-radial Affects the ELK Radial algorithm.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants