Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterative Longest Path Layerer #882

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Eddykasp
Copy link
Contributor

@Eddykasp Eddykasp commented Nov 4, 2022

An iterative version of the longest path layerer to adress #872. There is no longer a Stackoverflow exception for the example graph, however, the layout still takes too long with this version. The existing recursive version may be good enough for typical problems.

@Eddykasp Eddykasp marked this pull request as draft November 7, 2022 07:47
@Eddykasp
Copy link
Contributor Author

Eddykasp commented Nov 7, 2022

In BinaryIndexedTree in the rank method an IndexOutOfBoundsError now occurs with this example graph. Other tests are still passing.

@soerendomroes soerendomroes linked an issue Nov 29, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LongestPathLayerer causes StackOverflow exception
1 participant