Add toStack to Ordered Primitive Iterable #1068

DineshPurushothamacharya · 2021-02-19T13:13:18Z

Signed-off-by: Dinesh Purushothamacharya [email protected]

donraab

Thank you for the contribution @DineshPurushothamacharya. I've added comments inline. Please write tests for all of the toStack methods that have been added in the corresponding primitive test .stg files.

eclipse-collections-code-generator/src/main/resources/api/ordered/orderedPrimitiveIterable.stg

donraab · 2021-02-26T21:13:10Z

...ns-code-generator/src/main/resources/impl/list/immutable/immutablePrimitiveSingletonList.stg

+    @Override
+    public Mutable<name>Stack toStack()
+    {
+        return <name>Stacks.mutable.withAll(this);


This can be simplified to just add the single element to the stack as the toList and toSet methods do.

donraab · 2021-02-26T21:13:38Z

...ctions-code-generator/src/main/resources/impl/list/immutable/immutablePrimitiveEmptyList.stg

+    @Override
+    public Mutable<name>Stack toStack()
+    {
+        return <name>Stacks.mutable.withAll(this);


This can return an empty stack.

...ollections-code-generator/src/main/resources/impl/list/mutable/synchronizedPrimitiveList.stg

...ollections-code-generator/src/main/resources/impl/list/mutable/unmodifiablePrimitiveList.stg

donraab · 2021-02-26T21:21:30Z

...-code-generator/src/main/resources/impl/stack/immutable/immutablePrimitiveSingletonStack.stg

+    @Override
+    public Mutable<name>Stack toStack()
+    {
+        return <name>Stacks.mutable.withAll(this);


This can return a stack with a single item added.

donraab · 2021-02-26T21:22:48Z

...pse-collections-code-generator/src/main/resources/impl/stack/mutable/primitiveArrayStack.stg

+    @Override
+    public Mutable<name>Stack toStack()
+    {
+        return <name>Stacks.mutable.withAll(this);


This should use <name>Stacks.mutable.withAllReversed(this) to be consistent with the object stack.

donraab · 2021-02-26T21:24:55Z

...lections-code-generator/src/main/resources/impl/stack/mutable/synchronizedPrimitiveStack.stg

+    @Override
+    public Mutable<name>Stack toStack()
+    {
+        return <name>Stacks.mutable.withAll(this);


This should be:

synchronized (this.lock) { return this.stack.toStack(); }

Sure. I Will updated it.

donraab · 2021-02-26T21:26:07Z

...lections-code-generator/src/main/resources/impl/stack/mutable/synchronizedPrimitiveStack.stg

+    @Override
+    public Mutable<name>Stack toStack()
+    {
+        return <name>Stacks.mutable.withAll(this);


This should be:

synchronized (this.lock) { return this.stack.toStack(); }

donraab · 2021-02-26T21:26:55Z

...lections-code-generator/src/main/resources/impl/stack/mutable/unmodifiablePrimitiveStack.stg

+    @Override
+    public Mutable<name>Stack toStack()
+    {
+        return <name>Stacks.mutable.withAll(this);


This should be:

return this.stack.toStack()

Signed-off-by: Dinesh Purushothamacharya <[email protected]>

DineshPurushothamacharya · 2021-06-13T17:59:45Z

@donraab I have updated the project with all the review fixes and unit tests for the changes. Please do review it and let me know if any more changes required will be happy to fix them.

prathasirisha · 2022-03-18T18:31:49Z

@donraab I have updated the project with all the review fixes and unit tests for the changes. Please do review it and let me know if any more changes required will be happy to fix them.

Hi, @DineshPurushothamacharya could you please rebase your PR so one of us can review the changes. Thank you for your contribution!

donraab · 2023-05-09T01:33:59Z

Hi @DineshPurushothamacharya, I'd like to help get this PR reviewed and merged. There are a couple of changes to start with since this PR has been open for a couple years.

Update Since tags from 11.0 to 12.0 which will be the next major release
Rollback the changes to the XML files as they are unrelated to this PR
Rebase and squash your commits

Thanks!

DineshPurushothamacharya · 2023-05-11T17:55:46Z

Hi @DineshPurushothamacharya, I'd like to help get this PR reviewed and merged. There are a couple of changes to start with since this PR has been open for a couple years.

Update Since tags from 11.0 to 12.0 which will be the next major release

Rollback the changes to the XML files as they are unrelated to this PR

Rebase and squash your commits

Thanks!

Hello @donraab, sorry for the huge delay on this PR. I have made all the suggested changes, request you to verify it.

Thanks

donraab · 2023-05-15T02:39:38Z

Hi @DineshPurushothamacharya, looks like you have some actual issues to fix reported by the checkstyle build. Also, the EclipseFdn ECA check is failing. Do you have a signed ECA on file? If so, I will check and validate what the issue is. Thanks!

DineshPurushothamacharya · 2023-05-21T17:38:19Z

Hi @DineshPurushothamacharya, looks like you have some actual issues to fix reported by the checkstyle build. Also, the EclipseFdn ECA check is failing. Do you have a signed ECA on file? If so, I will check and validate what the issue is. Thanks!

Hi @donraab, I have fixed the checkstyle issue and EclipseFdn ECA. Please request to validate.

DineshPurushothamacharya · 2023-07-22T05:43:00Z

@donraab , @prathasirisha could you please review this PR? I would like to close this one.

donraab

Thank you for the contribution @DineshPurushothamacharya ! I have a couple minor changes requested and after that I will approve and merge.

donraab · 2023-08-05T01:38:15Z

...ode-generator/src/main/resources/test/list/immutable/immutablePrimitiveSingletonListTest.stg

+    public void toStack()
+    {
+        Mutable<name>Stack stack = this.classUnderTest().toStack();
+        Assert.assertEquals(stack, <name>Stacks.mutable.with(<(literal.(type))("1")>));


The arguments in the assertEquals should be reversed (expected, equals)

I have reversed the values for assertEquals.

donraab · 2023-08-05T01:39:56Z

...-code-generator/src/main/resources/test/stack/immutable/immutablePrimitiveArrayStackTest.stg

+    public void toStack()
+    {
+        Mutable<name>Stack stack = <name>Stacks.mutable.withAllReversed(<name>ArrayStack.newStackWith(<["1", "2", "3"]:(literal.(type))(); separator=", ">));
+        Assert.assertEquals(<name>ArrayStack.newStackWith(<["1", "2", "3"]:(literal.(type))(); separator=", ">).toStack(), stack);


The arguments in assertEquals should be reversed (expected, equals)

I have reversed the values for assertEquals.

Signed-off-by: Dinesh Purushothamacharya <[email protected]> Add toStack to Ordered primitive Iterable Signed-off-by: Dinesh Purushothamacharya <[email protected]> rebase with master Signed-off-by: Dinesh Purushothamacharya <[email protected]> rebase with master Signed-off-by: Dinesh Purushothamacharya <[email protected]> Add toStack to Ordered Primitive Iterable Signed-off-by: Dinesh Purushothamacharya <[email protected]> Fix checkstyle Issue Signed-off-by: Dinesh Purushothamacharya <[email protected]> Add unit tests to support toStack implmentation Signed-off-by: Dinesh Purushothamacharya <[email protected]> rebase rebase rebase rebase with master Signed-off-by: Dinesh Purushothamacharya <[email protected]> Add toStack to Ordered Primitive Iterable Signed-off-by: Dinesh Purushothamacharya <[email protected]> Revert "rebase" This reverts commit cb766b1. fix rebase issues restore xml files add .gitignore file Signed-off-by: Dinesh Purushothamacharya <[email protected]> fix checkstyle issues Signed-off-by: Dinesh Purushothamacharya <[email protected]> Fix checkstyle issue Signed-off-by: Dinesh Purushothamacharya <[email protected]> fix checkstyle issues Signed-off-by: Dinesh Purushothamacharya <[email protected]> Fix assertions

DineshPurushothamacharya · 2023-08-09T07:11:00Z

Thank you for the contribution @DineshPurushothamacharya ! I have a couple minor changes requested and after that I will approve and merge.

@donraab Thanks for pointing the mistakes. I have now fixed them. Please check once again and approve if its looks good to you.

DineshPurushothamacharya · 2023-09-28T06:01:24Z

Hello @donraab could you please approve and merge this PR?

DineshPurushothamacharya · 2023-10-31T15:47:32Z

Hello @donraab, I have fixed the review comments as per your suggestions. Can you please review it and merge this PR?

donraab · 2023-11-12T22:36:25Z

Hi @DineshPurushothamacharya, I am reviewing now. Thank you for your patience!

donraab · 2023-11-16T04:06:36Z

Hi @DineshPurushothamacharya, I was hoping to save you the trouble of rebasing your PR and tried using the GitHub Update Branch button for my first time. Unfortunately I did not realize the default behavior of the button is to merge, not rebase. Lesson learned. Would you be able to create a branch, cherry pick your one commit and submit a new PR and make sure it is rebased? I will review/approve and merge the new PR promptly, and close this PR. Thank you, and apologies for the extra work!

DineshPurushothamacharya · 2023-11-23T11:54:09Z

Hi @DineshPurushothamacharya, I was hoping to save you the trouble of rebasing your PR and tried using the GitHub Update Branch button for my first time. Unfortunately I did not realize the default behavior of the button is to merge, not rebase. Lesson learned. Would you be able to create a branch, cherry pick your one commit and submit a new PR and make sure it is rebased? I will review/approve and merge the new PR promptly, and close this PR. Thank you, and apologies for the extra work!

Hi @donraab, Thanks for reviewing it. As mentioned I have rebased the changes onto new branch. Please find the new review. Request you to review this one.
#1528

DineshPurushothamacharya mentioned this pull request Feb 19, 2021

Add toStack to Ordered primitive Iterable #1045

Open

donraab requested changes Feb 26, 2021

View reviewed changes

DineshPurushothamacharya added a commit to DineshPurushothamacharya/eclipse-collections that referenced this pull request Jun 13, 2021

Fixes eclipse#1068

8875579

Signed-off-by: Dinesh Purushothamacharya <[email protected]>

DineshPurushothamacharya force-pushed the dinesh branch from 8875579 to fc9b1a0 Compare April 21, 2022 09:12

DineshPurushothamacharya force-pushed the dinesh branch 2 times, most recently from 6226099 to 2db4669 Compare May 11, 2023 17:41

DineshPurushothamacharya force-pushed the dinesh branch from 2db4669 to 07a6be2 Compare May 11, 2023 18:12

DineshPurushothamacharya requested a review from donraab May 11, 2023 18:13

DineshPurushothamacharya force-pushed the dinesh branch 2 times, most recently from b7c03d4 to 27b58b8 Compare May 21, 2023 17:09

DineshPurushothamacharya force-pushed the dinesh branch from 27b58b8 to c08edea Compare June 6, 2023 09:19

motlin force-pushed the dinesh branch from c08edea to fd7cf01 Compare June 19, 2023 15:10

DineshPurushothamacharya force-pushed the dinesh branch from 403ebc5 to 01a7b5b Compare July 10, 2023 12:31

donraab requested changes Aug 5, 2023

View reviewed changes

DineshPurushothamacharya force-pushed the dinesh branch from 01a7b5b to 96cff3f Compare August 9, 2023 07:08

DineshPurushothamacharya requested a review from donraab October 31, 2023 15:47

Merge branch 'master' into dinesh

f9a15ba

donraab closed this Dec 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add toStack to Ordered Primitive Iterable #1068

Add toStack to Ordered Primitive Iterable #1068

DineshPurushothamacharya commented Feb 19, 2021

donraab left a comment

donraab Feb 26, 2021

DineshPurushothamacharya Mar 12, 2021

donraab Feb 26, 2021

DineshPurushothamacharya Mar 12, 2021

donraab Feb 26, 2021

donraab Feb 26, 2021

donraab Feb 26, 2021

DineshPurushothamacharya Mar 12, 2021

donraab Feb 26, 2021

donraab Feb 26, 2021

DineshPurushothamacharya commented Jun 13, 2021

prathasirisha commented Mar 18, 2022

donraab commented May 9, 2023

DineshPurushothamacharya commented May 11, 2023

donraab commented May 15, 2023 •

edited

Loading

DineshPurushothamacharya commented May 21, 2023

DineshPurushothamacharya commented Jul 22, 2023 •

edited

Loading

donraab left a comment •

edited

Loading

donraab Aug 5, 2023

DineshPurushothamacharya Aug 9, 2023

donraab Aug 5, 2023

DineshPurushothamacharya Aug 9, 2023

DineshPurushothamacharya commented Aug 9, 2023

DineshPurushothamacharya commented Sep 28, 2023

DineshPurushothamacharya commented Oct 31, 2023

donraab commented Nov 12, 2023

donraab commented Nov 16, 2023

DineshPurushothamacharya commented Nov 23, 2023

Add toStack to Ordered Primitive Iterable #1068

Add toStack to Ordered Primitive Iterable #1068

Conversation

DineshPurushothamacharya commented Feb 19, 2021

donraab left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DineshPurushothamacharya commented Jun 13, 2021

prathasirisha commented Mar 18, 2022

donraab commented May 9, 2023

DineshPurushothamacharya commented May 11, 2023

donraab commented May 15, 2023 • edited Loading

DineshPurushothamacharya commented May 21, 2023

DineshPurushothamacharya commented Jul 22, 2023 • edited Loading

donraab left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DineshPurushothamacharya commented Aug 9, 2023

DineshPurushothamacharya commented Sep 28, 2023

DineshPurushothamacharya commented Oct 31, 2023

donraab commented Nov 12, 2023

donraab commented Nov 16, 2023

DineshPurushothamacharya commented Nov 23, 2023

donraab commented May 15, 2023 •

edited

Loading

DineshPurushothamacharya commented Jul 22, 2023 •

edited

Loading

donraab left a comment •

edited

Loading