-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Update sonar-scanner
Github action
#743
ci: Update sonar-scanner
Github action
#743
Conversation
The old version of the `sonar-scanner` depends on nodejs 14 which is deprecated.
.github/workflows/sonarqube.yaml
Outdated
@@ -55,6 +59,7 @@ jobs: | |||
-Dsonar.login=${{ secrets.SONAR_TOKEN }} \ | |||
-Dsonar.organization=${{ github.repository_owner }} \ | |||
-Dsonar.projectKey="$(echo ${{ github.repository }} | tr / _)" \ | |||
-Dsonar.organization=eclipse \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure this is not needed/harmful for forks:
WARN: Property 'sonar.organization' with value 'eclipse' is overridden with value 'eclipse'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you are right. Missed that it was there already.
This is not working. I don't know why. Seems to be a problem with uploading the report. It might be an authorization problem. But I have not the right permissions to check that. |
The old version of the
sonar-scanner
depends onnodejs 14 which is deprecated.