examples: use getline() to read commands #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous approach works only if the terminal is operating in cannonical mode (input available line-by-line), which is not always true. getline() ensures that commands are always read correctly.
|
Hi @raiden00pl, thanks for your contribution. Nice to see on which platforms Wakaama is integrated. There are no regression tests for Apache NuttX yet, so we can not guarantee that we won't break NuttX with future changes. |
|
No problem with that. NuttX tries to be compatible with Linux as much as possible for a system dedicated to embedded applications, so it shouldn't be that easy to break NuttX support ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
examples: use getline() to read commands
The previous approach works only if the terminal is operating in cannonical mode (input available line-by-line), which is not always true. getline() ensures that commands are always read correctly.
With this change commands work properly on Apache NuttX