Implemented client side send operation #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parmi93
force-pushed
the
client_send_operation
branch
from
2e08ac6
to
02d94f7
Compare
|
The code looks good to me now. Thanks for your effort! Two improvements you could do for your commit:
|
parmi93
force-pushed
the
client_send_operation
branch
2 times, most recently
from
6b8fe2d
to
77c25db
Compare
|
Commits squashed and commit message subject line changed. |
parmi93
force-pushed
the
client_send_operation
branch
from
f66a04c
to
e18eaf5
Compare
|
Code formatted with |
Implemented send operation for client side, send operation was introduced with the LwM2M 1.1 standard. This PR is based on work from @sbertin-telular, specifically on send branch: https://github.com/sbertin-telular/wakaama/tree/send In this PR a bug that caused a memory leak has been fixed: sbertin-telular#1
parmi93
force-pushed
the
client_send_operation
branch
from
2198e17
to
d5c218c
Compare
|
Code formatted with |
|
Sorry for the delay. I did a quick smoke test and it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented send operation for client side, send operation was introduced with the LwM2M 1.1 standard.
This PR is based on work from @sbertin-telular, specifically on send branch:
https://github.com/sbertin-telular/wakaama/tree/send
In this PR a bug that caused a memory leak has been fixed:
sbertin-telular#1