Fix out of bound read in registration handling

In some cases the code tried to read past the registration payload.
eclipse-wakaama · Aug 15, 2023 · fc8585a · fc8585a
1 parent 21323a2
commit fc8585a
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 2 deletions.
diff --git a/core/registration.c b/core/registration.c
@@ -1604,8 +1604,7 @@ static int prv_getId(uint8_t * data,
                 }
                 // Ignore any unrecognized attribute
             }
-            if (data[limit] == REG_ATTR_SEPARATOR)
-            {
+            if (limit < length && data[limit] == REG_ATTR_SEPARATOR) {
                 limit += 1;
             }
             data += limit;

diff --git a/...ing/registration_handleRequest/crash_files/crash-4722541711a0a70b31362a66129f8d3b27449b29 b/...ing/registration_handleRequest/crash_files/crash-4722541711a0a70b31362a66129f8d3b27449b29
diff --git a/...ing/registration_handleRequest/crash_files/crash-b609a2dd5c6a5ce4fac6b76d1fdfd2841dca4402 b/...ing/registration_handleRequest/crash_files/crash-b609a2dd5c6a5ce4fac6b76d1fdfd2841dca4402