Chore/add miw and vault #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
# Conflicts: # charts/umbrella/Chart.yaml # charts/umbrella/values.yaml
evegufy
reviewed
Mar 21, 2024
There was a problem hiding this comment.
@ds-jhartmann I tested the change locally and when not using the keycloak from the miw but the centralidp instead the install is successful:
c84c06a
https://github.com/eclipse-tractusx/tractus-x-umbrella/actions/runs/8379432620
Thanks a lot, I added your suggestion :) |
evegufy
requested changes
Mar 22, 2024
evegufy
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
eclipse-tractusx/sig-release#418
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: