Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restructure chart and cleanup #46

Merged
merged 12 commits into from
Feb 1, 2024

Conversation

almadigabor
Copy link
Contributor

@almadigabor almadigabor commented Jan 26, 2024

Description

  • Clean up chart
  • Delete deprecated subcharts
  • Bump chart minor version to v0.3.0
  • Update copyright headers on modified files
  • Adjust values.yaml and Chart.yaml to only include Portal components for now

from #48:

  • feat: upgrade portal and iam subcharts to 23.12 release
  • chore(helm checks): run on every pr and rename workflow

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@almadigabor almadigabor self-assigned this Jan 26, 2024
@almadigabor
Copy link
Contributor Author

Hey @evegufy! Helm test fails as there are multiple resources with the same name rendered. This is a conflict between dependencies. Can you also have a look into this?

Helm install does work interestingly but you can reproduce the problem by running helm template umbrella charts/umbrella -f charts/umbrella/values.yaml > template.yaml. Then you'll see duplicate resources. This is also used by the chart-testing-action, that's why the workflow is failing.

@almadigabor almadigabor marked this pull request as ready for review January 26, 2024 10:50
@evegufy
Copy link
Contributor

evegufy commented Jan 26, 2024

Hey @evegufy! Helm test fails as there are multiple resources with the same name rendered. This is a conflict between dependencies. Can you also have a look into this?

Helm install does work interestingly but you can reproduce the problem by running helm template umbrella charts/umbrella -f charts/umbrella/values.yaml > template.yaml. Then you'll see duplicate resources. This is also used by the chart-testing-action, that's why the workflow is failing.

@almadigabor sure, I'll check it out next week.

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helm checks should work fine once you merge my pr #48
my guess on why there aren't duplicate resources after the upgrade of the portal and iam charts anymore: the central and sharedidp caused this, for the iam charts we use the chart from Bitnami as dependency and they must have improvedthe unique naming of resources from the version which we used for our 1.2.0 to the version which we used for our 2.0.0.

feat: upgrade portal and iam subcharts to 23.12 release
@evegufy evegufy changed the title Feat/chart restructure cleanup feat: restructure chart and cleanup Jan 29, 2024
charts/umbrella/Chart.yaml Show resolved Hide resolved
@almadigabor almadigabor merged commit ca7651c into main Feb 1, 2024
4 checks passed
@evegufy evegufy deleted the feat/chart-restructure-cleanup branch August 13, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants