Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move certs chart into subcharts #35

Closed

Conversation

fty4
Copy link
Member

@fty4 fty4 commented Aug 9, 2023

Description

As in other repos already the case charts should be included as via repo-filesystem.
This will allow to disable the components if required.
The common name here is subcharts to place the chart into.


Marco Lecheler [email protected] Mercedes-Benz Tech Innovation GmbH (ProviderInformation)

This will allow to manually disable the component if not required.
@almadigabor
Copy link
Contributor

almadigabor commented Aug 22, 2023

Hi @fty4! I think we should follow the official recommendation from helm to put the subcharts in the charts directory. You can still disable components using conditions like certsprovider.enabled and certsconsumer.enabled without the filesystem reference. I would just close this PR and open a new one with changes to the Chart.yaml like this:

dependencies:
  - alias: certsconsumer
    name: certs
    version: 0.1.0
    condition: certsconsumer.enabled
  - alias: certsprovider
    name: certs
    version: 0.1.0
    condition: certsprovider.enabled

@fty4
Copy link
Member Author

fty4 commented Sep 29, 2023

You are right - I am aware of this option but thought there is a downside when using the subchart multiple times.
I just tested it with a blank setup but it worked as expected.

So I think we do not need this change :)

@fty4 fty4 closed this Sep 29, 2023
@fty4 fty4 deleted the chore/subchart-certs branch September 29, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants