Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add SSI Credential Issuer #114

Merged
merged 10 commits into from
Aug 12, 2024

Conversation

mgarciaLKS
Copy link
Contributor

@mgarciaLKS mgarciaLKS commented Jul 30, 2024

Description

This pull request adds the SSI Credential Issuer to the umbrella chart.
It was proposed by my co-worker @gomezbc in the 29/07 meeting and has been carried out by @gomezbc and myself according to his approval.

  • In which Shared Services file should I enable the SSI Credential Issuer for the tests?

eclipse-tractusx/sig-release#710

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link

gitguardian bot commented Jul 30, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic High Entropy Secret c942144 charts/umbrella/values.yaml View secret
- - Generic High Entropy Secret c942144 charts/umbrella/values.yaml View secret
- - Generic High Entropy Secret ee95d3d charts/umbrella/values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

charts/umbrella/README.md Outdated Show resolved Hide resolved
charts/umbrella/README.md Outdated Show resolved Hide resolved
charts/umbrella/README.md Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
charts/umbrella/values.yaml Outdated Show resolved Hide resolved
@evegufy
Copy link
Contributor

evegufy commented Aug 5, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
🛠 Guidelines to remediate hardcoded secrets
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Hi @mgarciaLKS as those are test secrets, I skipped GitGuardian

@mgarciaLKS
Copy link
Contributor Author

@evegufy Thanks for the feedback.

I have made the changes mentioned above, I hope they are correct this time.

On the other hand, would there be a way to skip GitGuardian automatically and also run the remaining tests? So I wouldn't have to wait for you to do it manually, and I can fix the tests that fail dynamically?

Greetings.

charts/umbrella/values.yaml Outdated Show resolved Hide resolved
@evegufy
Copy link
Contributor

evegufy commented Aug 5, 2024

@evegufy Thanks for the feedback.

I have made the changes mentioned above, I hope they are correct this time.

On the other hand, would there be a way to skip GitGuardian automatically and also run the remaining tests? So I wouldn't have to wait for you to do it manually, and I can fix the tests that fail dynamically?

Greetings.

Hi @mgarciaLKS thanks for implementing the changes!

No, it's not possible to skip GitGuardian automatically but now that you're a project contributor (eclipse-tractusx/sig-infra#539) the remaining test should be triggered automatically without manual approval.

@mgarciaLKS
Copy link
Contributor Author

@evegufy One question, now that the test are divided in two shared services to optimize resources, in which Shared Services file should I enable the SSI Credential Issuer for the tests?

@evegufy
Copy link
Contributor

evegufy commented Aug 5, 2024

@evegufy One question, now that the test are divided in two shared services to optimize resources, in which Shared Services file should I enable the SSI Credential Issuer for the tests?

Hi @mgarciaLKS right, forgot about that, could you please add it to file 2?

@mgarciaLKS
Copy link
Contributor Author

@evegufy It seems to have worked :)

@evegufy evegufy merged commit 2452260 into eclipse-tractusx:upgrade/24.05 Aug 12, 2024
4 checks passed
@evegufy evegufy mentioned this pull request Oct 2, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants