Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: demand and capacity notification improvements #576

Merged
merged 4 commits into from
Oct 2, 2024
Merged

feat: demand and capacity notification improvements #576

merged 4 commits into from
Oct 2, 2024

Conversation

eschrewe
Copy link
Contributor

@eschrewe eschrewe commented Sep 4, 2024

Description

  • fixed/improved DemandAndCapacitySammMapper:
  • now properly distinguishes between Samms that came from a supplier or a customer, when identifying the affected materials
  • now using customermaterialnumber / suppliermaterialnumber fields in the samm/json payload
  • added unit tests for samm mapper
  • solves Add tests for serialization of SAMM models #465

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test correct mapping of all fields. Beside that you solved #486 ! Thanks a lot :)

...demandandcapacitynotification/logic/adapter/DemandAndCapacityNotificationSammMapperTest.java Show resolved Hide resolved
This was linked to issues Sep 9, 2024
Demand And Capacity Notification Endpoint does not accept materials #486
Closed
Add tests for serialization of SAMM models #465
Open
@tom-rm-meyer-ISST tom-rm-meyer-ISST removed a link to an issue Sep 9, 2024
Add tests for serialization of SAMM models #465
Open
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently only serialization has been checked with regard to material mapping. Please also add mapping assertions for deserialization.

...demandandcapacitynotification/logic/adapter/DemandAndCapacityNotificationSammMapperTest.java Show resolved Hide resolved
...demandandcapacitynotification/logic/adapter/DemandAndCapacityNotificationSammMapperTest.java Show resolved Hide resolved
...demandandcapacitynotification/logic/adapter/DemandAndCapacityNotificationSammMapperTest.java Show resolved Hide resolved
tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit c3a5477 into eclipse-tractusx:main Oct 2, 2024
13 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the feat/demandandcapacitytests branch October 2, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Demand And Capacity Notification Endpoint does not accept materials
2 participants
@eschrewe @tom-rm-meyer-ISST