Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add missing license information for code artefacts #527

Merged
merged 2 commits into from
Jul 26, 2024
Merged

chore: add missing license information for code artefacts #527

merged 2 commits into from
Jul 26, 2024

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Jul 26, 2024 •
edited
Loading

Description

During Quality Gate I realized, that license headers have been missing for code artifacts.

Added these license files and provided a small script for sanity checks.

Notes:

  • regression test has been conducted for safety reasons (beside helm install)
  • will be used as new 2.1.0 basis
  • Chart version not bumped as only license headers have been changed

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

@tom-rm-meyer-ISST tom-rm-meyer-ISST changed the title chore: add missing license information chore: add missing license information for code artefacts Jul 26, 2024
@tom-rm-meyer-ISST tom-rm-meyer-ISST marked this pull request as ready for review July 26, 2024 12:03
@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit a02bb35 into eclipse-tractusx:main Jul 26, 2024
12 of 13 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the chore/license branch July 26, 2024 12:30
@tom-rm-meyer-ISST tom-rm-meyer-ISST mentioned this pull request Jul 26, 2024
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhellmeier mhellmeier mhellmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-rm-meyer-ISST @mhellmeier