Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Erpadapter Trigger Service #474

Merged
merged 12 commits into from
Jul 11, 2024
Merged

Feat: Erpadapter Trigger Service #474

merged 12 commits into from
Jul 11, 2024

Conversation

eschrewe
Copy link
Contributor

Description

  • added service that receives notifications about incoming partner requests
  • this service runs a daemon thread, which periodically requests new updates from the erp adapter
  • configurable refresh interval and period after which new updates from the erp adapter are no longer triggered
  • solvers Create Integration for ERP Interface for Item Stock #310

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

@eschrewe
Copy link
Contributor Author

I will have a look at the failing chart lint test on thursday

@eschrewe
Copy link
Contributor Author

I will have a look at the failing chart lint test on thursday

fixed

@tom-rm-meyer-ISST tom-rm-meyer-ISST requested review from tom-rm-meyer-ISST and removed request for ReneSchroederLJ July 8, 2024 08:15
@tom-rm-meyer-ISST tom-rm-meyer-ISST linked an issue Jul 8, 2024 that may be closed by this pull request
Create Integration for ERP Interface for Item Stock #310
Closed
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! Also the discussion helped a lot!

Please check if we can add a manual trigger to the Dashboard via a button for the selected criteria similar as for all data updates and add documentation for configuration (Admin Guide + runtime view or concepts)

charts/puris/Chart.yaml Outdated Show resolved Hide resolved
charts/puris/values.yaml Outdated Show resolved Hide resolved
...ava/org/eclipse/tractusx/puris/backend/erpadapter/domain/model/ErpAdapterTriggerDataset.java Outdated Show resolved Hide resolved
...end/src/main/java/org/eclipse/tractusx/puris/backend/erpadapter/ErpAdapterConfiguration.java Show resolved Hide resolved
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Just had one camel case issue in the controller. Please check if the suggestion fits you well :)

...main/java/org/eclipse/tractusx/puris/backend/erpadapter/controller/ErpAdapterController.java Outdated Show resolved Hide resolved
tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 040ef55 into eclipse-tractusx:main Jul 11, 2024
13 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the feat/erp_adapter_trigger branch July 11, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Integration for ERP Interface for Item Stock
2 participants
@eschrewe @tom-rm-meyer-ISST