Feat/update helm charts #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dependency check will be solved in PR #42 |
tom-rm-meyer-ISST
requested changes
Sep 28, 2023
There was a problem hiding this comment.
Overall great effort! There are smaller things and few bigger ones
- increase readability for operator: frontend and backend application environment variables should have a prefix
- installation command is not as good as previously
- .env changes are wrong - please revert
Please also fix the KICS and Quality Gate critical issues
|
I added three new issues that shall cover improvements after this PR: |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tom-rm-meyer-ISST
requested changes
Oct 16, 2023
There was a problem hiding this comment.
Trivy found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
KICS found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
…a chart deployable
PaMarzec
force-pushed
the
feat/update-helm-charts
branch
from
ac78f6b
to
248c77b
Compare
tom-rm-meyer-ISST
approved these changes
Oct 26, 2023
This was referenced Oct 31, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the values.yaml and deployment.yaml in frontend and backend for their helm deployment.
Additionally it adds a deployable umbrella helm chart for the TRG 5.08 requirement.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: