Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/charts file structure #33

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Feat/charts file structure #33

merged 2 commits into from
Sep 25, 2023

Conversation

PaMarzec
Copy link
Contributor

@PaMarzec PaMarzec commented Sep 5, 2023 •
edited
Loading

Description

  • changed structure of charts folder(backend/charts & frontend/charts) to be under root folder
  • added docs folder under root folder with README.md

➡️ To complete the TRG 2.03 requirement.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@tom-rm-meyer-ISST
Copy link
Contributor

Solves #33.

The quality check run into a problem because it doesn't find the charts. Therefore I put a comment into a correlating issue in sig-infra. We're on hold here.

Opened issue #35 for product chart fix.

@PaMarzec
Copy link
Contributor Author

PaMarzec commented Sep 8, 2023

Issue #35 is going to be fixed with the feat/update-helm-charts branch.

@PaMarzec PaMarzec closed this Sep 8, 2023
@PaMarzec PaMarzec reopened this Sep 8, 2023
@PaMarzec
Copy link
Contributor Author

PaMarzec commented Sep 8, 2023

Accidently pressed on "Close with comment" instead of just "Comment"

@tom-rm-meyer-ISST
Copy link
Contributor

@mhellmeier could you please merge? Failed quality check is addressed via new issue and will be fixed in next work on helm chart.

mhellmeier
mhellmeier previously requested changes Sep 8, 2023
View reviewed changes
Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify that all participants have signed the ECA. The check of @PaMarzec commits still fails.

@PaMarzec
Copy link
Contributor Author

PaMarzec commented Sep 12, 2023 •
edited
Loading

@tom-rm-meyer-ISST @mhellmeier I edited the two commits so that i could sign them. The commits are verified now.

@tom-rm-meyer-ISST tom-rm-meyer-ISST mentioned this pull request Sep 15, 2023
Closed
mhellmeier
mhellmeier approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhellmeier mhellmeier merged commit 7625dcd into eclipse-tractusx:main Sep 25, 2023
9 of 11 checks passed
@PaMarzec PaMarzec deleted the feat/charts-file-structure branch October 19, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhellmeier mhellmeier mhellmeier approved these changes

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PaMarzec @tom-rm-meyer-ISST @mhellmeier