Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci: docker compose for local test scenario #24

Merged
merged 16 commits into from
Nov 3, 2023

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Aug 29, 2023

Description

Introduced a docker-compose for local test demonstration. Spins up following containers needed for edc 0.3.0

  • one PURIS backend for customer and supplier each
  • one PURIS frontend for customer and supplier each
  • one control plane for customer and supplier each
  • one data plane for customer and supplier each
  • one postgresql
  • one vault

It provides additional setup scripts and configuration for the given scenario.

Please note: fixed the secrets and then squashed. Tried multiple times as one path was seen as secret. Externalized all potential secrets into an .env

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@gitguardian
Copy link

gitguardian bot commented Aug 29, 2023

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

local/vault/Dockerfile Fixed Show fixed Hide fixed
local/vault/Dockerfile Fixed Show fixed Hide fixed
local/vault/Dockerfile Dismissed Show dismissed Hide dismissed
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KICS found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@tom-rm-meyer-ISST tom-rm-meyer-ISST force-pushed the ci/local-deployment branch 4 times, most recently from 0f7a43a to c9e8572 Compare August 29, 2023 13:25
@tom-rm-meyer-ISST
Copy link
Contributor Author

Quality check still fails because we need to incorporate this issue: eclipse-tractusx/sig-infra#230

@tom-rm-meyer-ISST
Copy link
Contributor Author

Updated license headers.

@mhellmeier
Copy link
Member

Regarding postgresql, remember to have a look at eclipse-tractusx/sig-infra#308

@tom-rm-meyer-ISST
Copy link
Contributor Author

Regarding quality checks: The TRG for base images only applies to publishing images. As we use it locally for integration test, it's fine. I added the exclusion already to the metadata file. As soon as the reusable workflow is ready, it will pass. See here.

@tom-rm-meyer-ISST
Copy link
Contributor Author

Regarding quality checks: The TRG for base images only applies to publishing images. As we use it locally for integration test, it's fine. I added the exclusion already to the metadata file. As soon as the reusable workflow is ready, it will pass. See here.

Release guideline workflow has been updated. Everything works out now!

Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different changes in the docker setup are necessary to get it working. I can fix it for you.

local/INSTALL.md Outdated Show resolved Hide resolved
local/daps/docker-compose.yaml Outdated Show resolved Hide resolved
local/docker-compose.yaml Outdated Show resolved Hide resolved
local/tractus-x-edc/docker-compose.yaml Outdated Show resolved Hide resolved
@tom-rm-meyer-ISST tom-rm-meyer-ISST mentioned this pull request Nov 3, 2023
Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since it is only a local deployment for testing purposes and the KICS issues are addressed in #79

@mhellmeier mhellmeier merged commit efe9aa5 into eclipse-tractusx:main Nov 3, 2023
11 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the ci/local-deployment branch November 28, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants