Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: product stock exchange message uses dash instead of camel case #15

Merged

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Aug 16, 2023

Description

Collection of fixes to get closer to the changes of the standardization candidate:

  • The exchanged message used dashes instead of the lower camel case annoation for requestId
  • Parameters have been messed up so that existing partner product stocks have not been updated.
  • Change of id usage in frontend

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@tom-rm-meyer-ISST tom-rm-meyer-ISST changed the title Fix/apply catenax standards Fix: product stock exchange message uses dash instead of camel case Aug 16, 2023
@tom-rm-meyer-ISST
Copy link
Contributor Author

@mhellmeier KICS and quality checks are fine for now. Regarding licence check, there has been no update in this branch. According to the log message it seems that the workflow searches for the old kind of dependency file for non-mono-repo. Could you please check?

@tom-rm-meyer-ISST tom-rm-meyer-ISST marked this pull request as ready for review August 16, 2023 06:12
@mhellmeier
Copy link
Member

I think the problem of the failed dependency check is based on an upstream bug. I reported it to the sig-infra team:
eclipse-tractusx/sig-infra#228

Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for me since the KICS fixes are addressed in #18.

@mhellmeier mhellmeier merged commit f959530 into eclipse-tractusx:main Aug 16, 2023
6 of 8 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the fix/apply-catenax-standards branch August 29, 2023 13:53
tom-rm-meyer-ISST pushed a commit that referenced this pull request Jun 19, 2024
feat: implemented the backend for Days of Supply
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants