Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): upgrade story book to support mdx files #264

Merged
merged 27 commits into from
Aug 12, 2024

Conversation

manojava-gk
Copy link
Contributor

@manojava-gk manojava-gk commented Aug 12, 2024

Description

update storybook versions and support mdx files
add new component specific mdx files
table component content also added

Why

move design guidelines to storybook from assets

Issue

#115 #223

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@manojava-gk manojava-gk requested a review from oyo August 12, 2024 06:01
@evegufy
Copy link
Contributor

evegufy commented Aug 12, 2024

@manojava-gk please resolve conflicts and link previous PR, as there were a lot of discussion going on

@manojava-gk
Copy link
Contributor Author

OLD PR - #210

@evegufy
Copy link
Contributor

evegufy commented Aug 12, 2024

IP Issues created:
[main] INFO A review is required for npm/npmjs/-/chromatic/11.7.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15843 .
[main] INFO A review is required for npm/npmjs/-/vite/5.4.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15844 .

@evegufy
Copy link
Contributor

evegufy commented Aug 12, 2024

@manojava-gk IP issues are already approved, you can update the DEPENDENCIES file :)

Copy link

sonarcloud bot commented Aug 12, 2024

@manojava-gk
Copy link
Contributor Author

@oyo PR is ready with necessary updates

Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

@oyo oyo merged commit 5c92cbe into eclipse-tractusx:main Aug 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

3 participants