Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(seeding-job)!: enable realm import with dynamic config #141

Merged
merged 55 commits into from
Oct 7, 2024

Conversation

evegufy
Copy link
Contributor

@evegufy evegufy commented Jun 27, 2024

Description

BEGIN_COMMIT_OVERRIDE
feat(seeding-job)!: enable seeding job for realm import and upgrade with dynamic configuration of redirect urls, client secrets, etc. for centralidp and sharedidp - previously only used for upgrading the CX-Central realm configuration for centralidp

  • remove realm import with Dkeycloak.migration.action=import
  • enable dynamic configuration of redirects, client secrets and bpn
  • enable user import in separate file
  • sharedidp
  • bpdm: enable new client and service accounts
  • remove excludedUserAttributes, not needed anymore
  • move config out of values into job for easier install configuration
  • remove hook from seeding job
  • await keycloak service before starting seeding job
  • create unique job names at helm upgrade to avoid running into "field is immutable" error
  • increase resource settings
  • set automountServiceAccountToken to false
  • set readOnlyRootFilesystem
  • set ephemeral-storage
  • remove documentation for post-install configuration
  • enable option for TLS connection

feat(bpdm): consolidate description of new service accounts in centralidp
feat: improve secret handling and remove obsolete secrets
feat: move to standalone architecture for database dependency
feat: set default replica count to 1
chore: update chart testing
END_COMMIT_OVERRIDE

Why

#86

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my changes
  • I have successfully tested my changes
  • I have added comments in the default values.yaml file with helm-docs syntax ('# -- ') if relevant for installation
  • I have commented my changes, particularly in hard-to-understand areas

spec:
restartPolicy: Never
containers:
- name: {{ include "sharedidp.fullname" . }}-realm-seeding

Check warning

Code scanning / SonarCloud

Storage limits should be enforced

<!--SONAR_ISSUE_KEY:AZBbNzFtf-N3-JRK2R3j-->Specify a storage limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=eclipse-tractusx_portal-iam&issues=AZBbNzFtf-N3-JRK2R3j&open=AZBbNzFtf-N3-JRK2R3j&pullRequest=141">SonarCloud</a></p>
Copy link

sonarcloud bot commented Jul 1, 2024

@evegufy evegufy force-pushed the feat/86-seed-variables-secrets branch from fb4c010 to d17cc17 Compare September 17, 2024 14:00
- remove realm import with Dkeycloak.migration.action=import
- start enabling of CX-Central realm import with seeding job (up to now the seeding job was only used when upgrading the realm config)
- start enabling of client secret seeding
to avoid running into "field is immutable" error
improve secrets
remove excludedUserAttributes, not needed anymore
increase resource settings
update docs
@evegufy evegufy changed the title feat: change realm import to enable dynamic config feat(seeding-job)!: enable realm import with dynamic configuration Oct 2, 2024
@evegufy evegufy marked this pull request as ready for review October 2, 2024 23:33
@evegufy evegufy added this to the Release 24.12 milestone Oct 2, 2024
@evegufy evegufy requested a review from Phil91 October 2, 2024 23:34
Copy link

sonarcloud bot commented Oct 7, 2024

@evegufy evegufy changed the title feat(seeding-job)!: enable realm import with dynamic configuration feat(seeding-job)!: enable realm import with dynamic config Oct 7, 2024
@evegufy evegufy merged commit 5ed14ce into main Oct 7, 2024
8 checks passed
@evegufy evegufy deleted the feat/86-seed-variables-secrets branch October 7, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

2 participants