Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demand and Capacity Management KIT 24.12 #1063

Open
wants to merge 261 commits into
base: main
Choose a base branch
from
Open

Demand and Capacity Management KIT 24.12 #1063

wants to merge 261 commits into from
+4,395 −1,101

Conversation

ClosedSourcerer
Copy link
Contributor

@ClosedSourcerer ClosedSourcerer commented Oct 21, 2024 •
edited
Loading

Description

This PR introduces the Next Version of the Demand and Capacity Management KIT

Addressed Issues

eclipse-tractusx/sig-release#838
eclipse-tractusx/sig-release#799
eclipse-tractusx/sig-release#780
eclipse-tractusx/sig-release#773
eclipse-tractusx/sig-release#772
eclipse-tractusx/sig-release#771
eclipse-tractusx/sig-release#770
eclipse-tractusx/sig-release#769
eclipse-tractusx/sig-release#766

Added

Changed

Bug Fixes

  • Removed Catena-X NG reference
  • Unified License Notice for DCM KIT
  • Renamed DCM KIT in the sidebar and header into Demand and Capacity Management KIT in order to be consistent with the other KITs

Pre-review checks

Docusaurus builds locally all touched pages run fine locally

Please ensure to do as many of the following checks as possible, before asking for committer review:

Frank-Globisch and others added 30 commits September 28, 2024 07:25
@Frank-Globisch
Update nesting.md with relative image path
74daf25
@ClosedSourcerer
Update changelog.md
cea1855
@lanfrans
Update glossary.md
4dabc17
@lanfrans
Update glossary.md
d984f2d 
Improvements (Came Casing, links...)
@lanfrans
Update glossary.md
7fc1f7d 
WeekBasedMaterialDemand added
@lanfrans
Update glossary.md
4b1b219 
Demand fluctuation eliminated,
@ClosedSourcerer
Added links back from test- customer and test-supplier to overview#te…
25a5914 
…sting-a-dcm-application
@ClosedSourcerer
Minor Fixes / Copy Paste errors
1e21339
@ClosedSourcerer
Update changelog.md
ba11f9d
@ClosedSourcerer
Update changelog.md
d1bce97
@ClosedSourcerer
Update test-customer.md
0c19e29
@ClosedSourcerer
Update test-supplier.md
2e57764
@lanfrans
Update glossary.md
72511d9 
Licences
@ClosedSourcerer
Added KIT Header
7693de5
@ClosedSourcerer
Update nesting.md
bc5c1aa
@lanfrans
Update glossary.md
642baa4 
licences
@kenobi79
Update delta-production.md
aa49fa6
@kenobi79
Update load-factors.md
6357813
@Frank-Globisch
Update nesting.md with changing </br> to <br/> as per PMA feedback
e792814
@Frank-Globisch
Update nesting.md with changed links to picture/WkBsdCG page
12e51f8
@ClosedSourcerer
Commented BlockBeta Mermaid out to ensure that the page builds
5e354a3 
SVGs need to be added
@ClosedSourcerer
Added Header back in
8d6c9a4
@ClosedSourcerer
Added Header back in
63d9b69
@pdequick
Update business-process_capacity-types_example1.svg.license
617da66
@pdequick
Update business-process_capacity-types_example2.svg.license
05d7992
@pdequick
Update business-process_capacity-types_example1.svg.license
f40972d
@pdequick
Update business-process_capacity-types_example3.svg.license
31dbb4e
@pdequick
Update business-process_capacity-types_example4a.svg.license
c0eccab
@pdequick
Update business-process_capacity-types_example4b.svg.license
64cdbf8
@pdequick
Update business-process_capacity-types_example_legend.svg.license
25179e4
@ClosedSourcerer
Copy link
Contributor Author

@pdequick
@lanfrans
@Frank-Globisch

Please, as previously mentioned, take care of linking your github and eclipse accounts as well as signing the ECA Eclipse contributors agreement.

@ClosedSourcerer

This comment was marked as resolved.

Sign in to view
@ClosedSourcerer

This comment was marked as resolved.

Sign in to view
@stephanbcbauer
Copy link
Member

@jSchuetz88 @stephanbcbauer

I am quite convinced, that the GitRunner is broken: image

The referenced Image file does exist, is a correctly formated .svg and can be previewed / build locally.

Maybe some stupid character limit for the total file length, as we referenced path is >127 chars?

@ClosedSourcerer I think the naming is not correct. In the file its Legend and in the markdown you are referencing legend

https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/blob/d027ce44dc5391e98ff0a08380500a9dcaa00f9f/docs-kits/kits/Demand%20and%20Capacity%20Management%20Kit/adoption-view/use-case/resources/business-process_DeltaProduction_functional_Legend.svg

@stephanbcbauer
Copy link
Member

stephanbcbauer commented Oct 21, 2024 •
edited
Loading

But I think we have some bigger issues ;) Markdown linting can be solved ⇾ easy, but there are some contributors who didn't sign the ECA? That's a problem.

And for this PR we need IP Ticket because of the huge number of changes. Can you change here somehow the working model? No committer would be able to review this PR

@ClosedSourcerer
Rename business-process_DeltaProduction_functional_Legend.svg to busi…
025dc9a 
…ness-process_DeltaProduction_functional_legend.svg
@ClosedSourcerer
Rename business-process_DeltaProduction_functional_Legend.svg.license…
c0fc14a 
… to business-process_DeltaProduction_functional_legend.svg.license
@ClosedSourcerer
Copy link
Contributor Author

But I think we have some bigger issues ;) Markdown linting can be solved ⇾ easy, but there are some contributors who didn't sign the ECA? That's a problem.

And for this PR we need IP Ticket because of the huge number of changes. Can you change here somehow the working model? No committer would be able to review this PR

@MWADCM
@LukasSchmetz

  1. As expert group lead the working model is your issue.
  2. Please also initiate the IP Ticket with our designated commiter.
  3. @eckardg Also contacted me regarding @lanfrans requirement for the Eclipse account and ECA. Please take care of this as well

@stephanbcbauer
Copy link
Member

But I think we have some bigger issues ;) Markdown linting can be solved ⇾ easy, but there are some contributors who didn't sign the ECA? That's a problem.
And for this PR we need IP Ticket because of the huge number of changes. Can you change here somehow the working model? No committer would be able to review this PR

@MWADCM @LukasSchmetz

  1. As expert group lead the working model is your issue.
  2. Please also initiate the IP Ticket with our designated commiter.
  3. @eckardg Also contacted me regarding @lanfrans requirement for the Eclipse account and ECA. Please take care of this as well

Meanwhile i created the IP Issue

@ClosedSourcerer
Copy link
Contributor Author

@jSchuetz88
An exact date (yyyy-mm-dd) for the release of the 24.12 KIT is required.

docs-kits/next/kits/Demand and Capacity Management Kit/changelog needs to be updated accordingly

jschu1
jschu1 approved these changes Oct 22, 2024
View reviewed changes
Copy link

@jschu1 jschu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement

@ClosedSourcerer
Copy link
Contributor Author

@jSchuetz88

  • When the KIT gets released with 24.12 should the changelog.md of tractus-X (https://eclipse-tractusx.github.io/CHANGELOG/) get changed as well in order to reflect the move from /DCM-KIT/ to /Demand and Capacity Management KIT/

@ClosedSourcerer
Updated KITs Gallery to reflect the move of the DCM KIT
14e20f1
@ClosedSourcerer
Fixed Links from other Content to DCM-KIT
811df21 
2 Fixes in one.
1. adoption-view.md does not exist anymore
2. rename DCM-KIT to Demand and Capacity Management Kit
@ClosedSourcerer
Fixed API InfoPath for DCM-KIT
d81497b 
DCM-KIT got moved to Demand and Capacity Management Kit. InfoPath needs to reflect this.
@ClosedSourcerer
fixed plugin generated sidebar.js for 24.08 DCM KIT
f9c38cd 
KIT got moved from DCM-KIT to Demand and Capacity Management Kit
@ClosedSourcerer
Replaced CatenaX-NG reference in versioned DCM-KIT
d4daf90
@ClosedSourcerer
Added missing anchor text to QnA links
b603a7d
@ClosedSourcerer
spelling and grammar
37a8f5f
@stephanbcbauer
Copy link
Member

But I think we have some bigger issues ;) Markdown linting can be solved ⇾ easy, but there are some contributors who didn't sign the ECA? That's a problem.
And for this PR we need IP Ticket because of the huge number of changes. Can you change here somehow the working model? No committer would be able to review this PR

@MWADCM @LukasSchmetz

  1. As expert group lead the working model is your issue.
  2. Please also initiate the IP Ticket with our designated commiter.
  3. @eckardg Also contacted me regarding @lanfrans requirement for the Eclipse account and ECA. Please take care of this as well

Meanwhile i created the IP Issue

@jSchuetz88 , @ClosedSourcerer Wow this was fast -> IP Tickets was approved

image

kenobi79
kenobi79 approved these changes Oct 25, 2024
View reviewed changes
Copy link

@kenobi79 kenobi79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschu1 jschu1 jschu1 approved these changes

@MWADCM MWADCM MWADCM approved these changes

@kenobi79 kenobi79 kenobi79 approved these changes

@danielmiehle danielmiehle Awaiting requested review from danielmiehle

@stephanbcbauer stephanbcbauer Awaiting requested review from stephanbcbauer

@LukasSchmetz LukasSchmetz Awaiting requested review from LukasSchmetz

@jSchuetz88 jSchuetz88 Awaiting requested review from jSchuetz88

@Grand-Thibault Grand-Thibault Awaiting requested review from Grand-Thibault

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.