Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore errors on plugin download #388

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

jfaltermeier
Copy link
Contributor

@jfaltermeier jfaltermeier commented Sep 2, 2024

What it does

Do not ignore errors on plugin download

Also Update to Theia 1.53.1 and update metadata for 1.52.0 release via Jenkinsfile

Contributed on behalf of STMicroelectronics

How to test

Review checklist

Reminder for reviewers

@jfaltermeier jfaltermeier marked this pull request as ready for review September 2, 2024 14:13
@tsmaeder
Copy link
Contributor

tsmaeder commented Sep 3, 2024

@msujew any idea why this is failing on mac only?

* also update to Theia 1.53.1

Contributed on behalf of STMicroelectronics
Copy link
Contributor

@sgraband sgraband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jfaltermeier jfaltermeier merged commit e103d54 into master Sep 4, 2024
6 checks passed
@jfaltermeier jfaltermeier deleted the jf/plugin-downloads branch September 4, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants