[471] Allow the workspacePath to be reset in the SelectImageDialog #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlennPlou
added
type: enhancement
A new button "Reset Image Style" has been added to reset the WorkspaceImage assigned to a DDiagramElement while preserving all other style modifications. Bug: #471 Signed-off-by: Glenn Plouhinec <[email protected]>
GlennPlou
force-pushed
the
gpl/enh/471
branch
from
e057670
to
d8d58ee
Compare
GlennPlou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done
A new button "Reset Image Style" has been added to reset the WorkspaceImage assigned to a DDiagramElement while preserving all other style modifications.
Steps to validate:
issue_471in your workspace from issue_471.zip, openissue_471 package entitiesdiagram, selectNewEclass1, openPropertiesview and theError Logview.Set style to workspace imagebutton from tabbar orAppearancetab inPropertiesviewExpected: The dialog appears. The image path field refers to the actual image
issue_471/images/green_beetle.png. The "Reset Image Style" button is enabled. "OK" button is disabled.Expected: The "Reset Image Style" button is disabled. OK button is enabled. the path is empty.
Expected: The path refers to
issue_471/images/blue_beetle.png. The "Reset Image Style" button is enabled. "OK" button is disabled.Expected: The path is updated with the actual Workspace Image
issue_471/images/green_beetle.png. The "Reset Image Style" button is enabled. "OK" button is disabled.Expected: The style of the node has been updated: the image is not even used, and other custom features are preserved (bold, italic, color label, size label...)