Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR to Fix 396 wrong border node creation location #455

Open
wants to merge 5 commits into
base: lre/enh/426-GMFHelper
Choose a base branch
from
Open

PR to Fix 396 wrong border node creation location #455

wants to merge 5 commits into from

Commits on Sep 27, 2024

  1. [396] Add test to reveal the wrong border node location creation problem 

    Bug: #396
    @lredor
    lredor committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    19bb5c9 View commit details
    Browse the repository at this point in the history

  2. [cleanup] Remove dead-code in internal class 

    Remove parameter in private method that is always true.
    @peransin-obeo @lredor
    peransin-obeo authored and lredor committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    57a638d View commit details
    Browse the repository at this point in the history

  3. [cleanup] Remove dead or redundant code for LayoutData 

    Code has leftovers after some refactoring.
    @peransin-obeo @lredor
    peransin-obeo authored and lredor committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    8b5624a View commit details
    Browse the repository at this point in the history

  4. [cleanup] Factorize methods in CreationUtil

    @peransin-obeo @lredor
    peransin-obeo authored and lredor committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    1f811fb View commit details
    Browse the repository at this point in the history

  5. [396] Adapt NodeCreationEditPolicy to compute the target location 

    - Constructors of CreationUtil have been improved to directly have
LayoutData as parameter instead of location and size. Indeed, the
location is relative to the parent edit part and for border nodes, the
parent edit part is not systematically the "host" of the called policy.
- In NodeCreationEditPolicy, in case of border nodes, the "host edit
part" is not systematically considered (to compute the RootLayoutData
for example). The correct edit part, a parent of the host, is computed
according to the mapping defined in the used tool.

Bug: #396
    @lredor
    lredor committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    ec2c328 View commit details
    Browse the repository at this point in the history